Review Request 123253: dolphin: Navigate to parent folder selects child folder

[Emmanuel Pescosta]

> On Nov. 19, 2015, 12:20 p.m., Emmanuel Pescosta wrote:
> > src/urlutil.h, line 25
> > <https://git.reviewboard.kde.org/r/123253/diff/1/?file=360008#file360008line25>
> >
> >     use a namespace instead of a class
> >     
> >     but ... maybe we can move firstChildUrl to global.h/.cpp?
> 
> Gregor Mi wrote:
>     I thought "global.h/.cpp" kind of classes tend to blow up. Interestingly global.h contains only two methods which are also URL related: validateUris and homeUrl. So what about moving those to urlutil.h?
> 
> Gregor Mi wrote:
>     Which namespace should I choose (Dolphin or UrlUtil)? Or really move it to global.*?

> So what about moving those to urlutil.h?

Good idea. Should be an extra patch ;)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123253/#review88587
-----------------------------------------------------------


On Jan. 24, 2016, 5:14 p.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123253/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2016, 5:14 p.m.)
> 
> 
> Review request for Dolphin and Emmanuel Pescosta.
> 
> 
> Bugs: 335616
>     https://bugs.kde.org/show_bug.cgi?id=335616
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This is a first working implementation of the feature suggestion filed in the ticket https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: Navigate to parent folder selects child folder".
> 
> In short, this is what is does: Whenever the dolphin view is initialized to show the contents of a new URL (e.g. "/home/x/test") it will be checked if the new URL is a parent of the previous displayed URL (e.g. "/home/x/test/documents/aaa"). If the check is successful, then the common child (in this example: "/home/x/test/documents/") folder item will be selected and scrolled into view.
> 
> 
> Diffs
> -----
> 
>   src/dolphinviewcontainer.h 62f91100e9e5d457edd6f4d927c87610335834d7 
>   src/dolphinviewcontainer.cpp 8fea3ba9d0bb8389d89724b9f0cd74605c0286fe 
>   src/tests/CMakeLists.txt 22a8b48491fa7ac88ce1b29aecb20192837dd7ea 
>   src/tests/urlutiltest.cpp PRE-CREATION 
>   src/urlutil.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123253/diff/
> 
> 
> Testing
> -------
> 
> - unit test passes
> - Played around with dolphin: enter URL manually, navigate via click in the item view, navigate via click in kurlnavigator, navigate with Alt+Left, Alt+Right, Alt+up, Backspace
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160128/c5b3f8c8/attachment.htm>