Review Request 123253: dolphin: Navigate to parent folder selects child folder

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123253/#review91719
-----------------------------------------------------------



Looks good otherwise! :)


src/tests/urlutiltest.cpp (lines 35 - 41)
<https://git.reviewboard.kde.org/r/123253/#comment62659>

    not needed



src/urlutil.h (line 26)
<https://git.reviewboard.kde.org/r/123253/#comment62655>

    make it a namespace instead ;)
    
    namespace Dolphin {
    namespace UrlUtil {
    
    }
    }



src/urlutil.h (lines 66 - 93)
<https://git.reviewboard.kde.org/r/123253/#comment62657>

    const if possible



src/urlutil.h (lines 76 - 78)
<https://git.reviewboard.kde.org/r/123253/#comment62656>

    Doesn't QUrl::isParentOf prevent this (IHMO currentUrl is not a parent of lastUrl in this case)? If yes, please remove the if or replace it with an assert.



src/urlutil.h (line 82)
<https://git.reviewboard.kde.org/r/123253/#comment62658>

    QLatin1Char


- Emmanuel Pescosta


On Jan. 24, 2016, 5:14 p.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123253/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2016, 5:14 p.m.)
> 
> 
> Review request for Dolphin and Emmanuel Pescosta.
> 
> 
> Bugs: 335616
>     https://bugs.kde.org/show_bug.cgi?id=335616
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This is a first working implementation of the feature suggestion filed in the ticket https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: Navigate to parent folder selects child folder".
> 
> In short, this is what is does: Whenever the dolphin view is initialized to show the contents of a new URL (e.g. "/home/x/test") it will be checked if the new URL is a parent of the previous displayed URL (e.g. "/home/x/test/documents/aaa"). If the check is successful, then the common child (in this example: "/home/x/test/documents/") folder item will be selected and scrolled into view.
> 
> 
> Diffs
> -----
> 
>   src/dolphinviewcontainer.h 62f91100e9e5d457edd6f4d927c87610335834d7 
>   src/dolphinviewcontainer.cpp 8fea3ba9d0bb8389d89724b9f0cd74605c0286fe 
>   src/tests/CMakeLists.txt 22a8b48491fa7ac88ce1b29aecb20192837dd7ea 
>   src/tests/urlutiltest.cpp PRE-CREATION 
>   src/urlutil.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123253/diff/
> 
> 
> Testing
> -------
> 
> - unit test passes
> - Played around with dolphin: enter URL manually, navigate via click in the item view, navigate via click in kurlnavigator, navigate with Alt+Left, Alt+Right, Alt+up, Backspace
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160128/8541a0c4/attachment.htm>