Review Request 126771: [CLAZY] Fixed all level 1 and level 2 warnings with small exceptions (see description)

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Thu Jan 28 20:38:40 GMT 2016 


> On Jan. 16, 2016, 5:25 p.m., Aleix Pol Gonzalez wrote:
> > src/kitemviews/kfileitemlistview.cpp, line 169
> > <https://git.reviewboard.kde.org/r/126771/diff/1/?file=431765#file431765line169>
> >
> >     What warning is this coming from?
> 
> Artur Puzio wrote:
>     Must be foreach with STL container causes deep-copy, but I have to recheck as indexes looks like it's not a STL container
> 
> Artur Puzio wrote:
>     Just checked, the previous version causes the warnings: `src/kitemviews/kfileitemlistview.cpp:169:5: warning: foreach with STL container causes deep-copy (KItemSet) [-Wclazy-foreach]`
> 
> Aleix Pol Gonzalez wrote:
>     Must be because it's not a Qt container. I'm not sure whether it's a false-positive, as it's not an STL one, but a custom container. I'd remove it, although it's up to the maintainer.

This is a really fast and optimized QSet-like container written by Frank, please add him to this review request.


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126771/#review91185
-----------------------------------------------------------


On Jan. 28, 2016, 6 p.m., Artur Puzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126771/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2016, 6 p.m.)
> 
> 
> Review request for Dolphin, Aleix Pol Gonzalez and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Fixed warning: `QString::fromLatin1()` being passed a literal [-Wclazy-qstring-uneeded-heap-allocations] with FIXIT
> Fixed warning: `QString::operator=(QLatin1String("literal")` [-Wclazy-qstring-uneeded-heap-allocations] with FIXIT
> Fixed warning: foreach with STL container causes deep-copy (*) [-Wclazy-foreach]
> Fixed warning: Pass small and trivially-copyable type by value (*) [-Wclazy-foreach]
> Fixed warning: Use `QVariant::toFoo()` instead of QVariant::value<Foo>() [-Wclazy-variant-sanitizer]
> Fixed warning: Don't call * on temporary [-Wclazy-detaching-temporary]
> Fixed warning: Use `midRef()` instead [-Wclazy-qstring-ref]
> Fixed warning: Reserve candidate [-Wclazy-reserve-candidates]
> Fixed warning: `QString(QLatin1String)` being called [-Wclazy-qstring-uneeded-heap-allocations] manually
> Fixed warning: * [-Wclazy-rule-of-three]
> Fixed warning: Old Style Connect [-Wclazy-old-style-connect]
> Fixed warning: `QString(const char*)` being called [-Wclazy-qstring-uneeded-heap-allocations] manually
> Fixed warning: Use `QDateTime::currentDateTimeUtc().toTime_t()` instead [-Wclazy-qdatetime-utc]
> Fixed warning: Use `QHash<K,T>` instead of `QMap<K,T>` when K is a pointer [-Wclazy-qmap-with-key-pointer]
> Fixed warning: Pass small and trivially-copyable type by value [-Wclazy-function-args-by-ref] (two warnings)
> Fixed warning: * is missing a Q_OBJECT macro [-Wclazy-missing-qobject]
> 
> Warnings left:
> warnings in gerated files
> Wclazy-function-args-by-ref
> non clazy warnings
> 2 warnings: Old Style Connect [-Wclazy-old-style-connect] in src/panels/terminal/terminalpanel.cpp
> 
> 
> Diffs
> -----
> 
>   src/dbusinterface.cpp 366fa99507dd005142cbb0655da4863c2006e86b 
>   src/dolphincontextmenu.cpp af283cf009f7e6d17a017d0e0df922d5127af7f6 
>   src/dolphindockwidget.cpp 1e83ef841b379ed8a389e89c83964fcdb172d1a3 
>   src/dolphinmainwindow.cpp 81c55e814c26085adfd2a9bc69fee401dc3505ed 
>   src/dolphinnewfilemenu.cpp 87f0932d87036c4f2b1848878e42479e05b7bde4 
>   src/dolphinpart.h 9f0ed55704443149f4dfea33202db0df50aea49a 
>   src/dolphinpart.cpp 1c0d611b9913a3e7d606d43986e997e03ef32ce8 
>   src/dolphinrecenttabsmenu.cpp 1087a38e45bf7eba1d23434303fa764c3fbe7f47 
>   src/dolphinremoveaction.cpp 7ea4e4f79e42d72e6dc08990ca470ede073e2234 
>   src/dolphintabbar.cpp dbd324db56c29fa21a760dfc0e42434a3ff281d0 
>   src/dolphintabpage.cpp 6d55ebeb2a6ed997dbeb5fcf8e470fe6343751a7 
>   src/dolphintabwidget.cpp 0b1f07e0e22b8539ef53576a810afaec0eda3d8b 
>   src/dolphinviewcontainer.cpp 6ceb18d6fe610ffa4d59be41e42cc355a4aaae07 
>   src/filterbar/filterbar.cpp 82d5f549ea87d6b3ea458b3a46f2c342261d105b 
>   src/kitemviews/kfileitemlistview.cpp a740a3a23ab5f8bf8902dccb9a6dd9d1c3cdc860 
>   src/kitemviews/kfileitemmodel.cpp 5f6fed0dcb4ca865c4d9a53bccc8c8824e1173d3 
>   src/kitemviews/kfileitemmodelrolesupdater.cpp 9f89de8e72d4172de8b787fc2c8e82753a026321 
>   src/kitemviews/kitemlistcontainer.cpp 94b49dbdeca96da4aac42f8dadb8f3535b0ff82d 
>   src/kitemviews/kitemlistselectionmanager.cpp 46b77f7e42304cd548c090667a1cfe10733782da 
>   src/kitemviews/kitemlistview.cpp df65399299ba30d48af59678d6b75f8bbb124478 
>   src/kitemviews/kitemlistviewaccessible.cpp 7b1605a0c8451184b9095643d18a5f7f8383cabb 
>   src/kitemviews/kitemlistwidget.h ae99a1f29992910c1f8cdec11132b46207790ecc 
>   src/kitemviews/kitemset.h 385010f7d634fd53b204995588b590aaf4ad2ad1 
>   src/kitemviews/kitemset.cpp f855368c1457e8664739a0a95c0b83fa5ccd55c7 
>   src/kitemviews/kstandarditemlistwidget.h b476441722b1feafa71e0eec6b4810020cf19fc4 
>   src/kitemviews/kstandarditemlistwidget.cpp 1112460a9670941ddc52b545fe1c9f8965385b9f 
>   src/kitemviews/private/kbaloorolesprovider.cpp 920ce0671d57d832ecfcee960dd3964d403bc699 
>   src/kitemviews/private/kfileitemclipboard.cpp e127678535aca1f63b747d91824dc23c2ffa457f 
>   src/kitemviews/private/kitemlistselectiontoggle.cpp d4081a690799ee82b1576b5bfbc51e1b8b0ee103 
>   src/kitemviews/private/kitemlistsizehintresolver.cpp 1d8067026d15281eac181523337bfb3af4a29a65 
>   src/main.cpp 9610753d8994dd4e65d77cc9100694fa9625b87b 
>   src/panels/folders/folderspanel.cpp 13df9019bf010729b8e60d850c8d51025976de66 
>   src/panels/folders/treeviewcontextmenu.cpp e45fcd67e09692fe668ce00df40b477ddbf3101c 
>   src/panels/information/filemetadataconfigurationdialog.cpp 2f8c160378c796b9a1800b78ed561cd32748101d 
>   src/panels/information/informationpanelcontent.cpp c18d4738ec6e9b09d989554227b1e494a170a00c 
>   src/panels/information/phononwidget.cpp 1d6361f19d26d86ceccf597dfa21f0e5b7a4d16b 
>   src/panels/places/placesitem.cpp 2a9c88e4eaf1e5811c2421396afc8649858bd2df 
>   src/panels/places/placesitemeditdialog.cpp d035b0403f856b597b88dc96e775380b45f40945 
>   src/panels/places/placesitemmodel.cpp 0d8ac6981def9a3a68d1d7fa6fde98cd885b160b 
>   src/panels/places/placespanel.cpp 50ed7e73aacfa6483122f32f7149232ab58fb302 
>   src/panels/terminal/terminalpanel.cpp ee88bd4c5aad508e0ca6bd6ddcaa5e5f7b446827 
>   src/search/dolphinfacetswidget.cpp 2425e0b35ded8c4133960bb5903970e4a71e9ec0 
>   src/search/dolphinsearchbox.cpp a925a97c9c663c198b7c129f9dac965b31d354ac 
>   src/settings/additionalinfodialog.cpp 783f5685ee04da64a71075ea4d1bfcd474b1ee0b 
>   src/settings/dolphinsettingsdialog.cpp 4f9a20de443cddfb6e0f7615c60e1b7bd3dafe68 
>   src/settings/general/confirmationssettingspage.cpp 264024abd354f89659431a58a2371f025e70e0c9 
>   src/settings/general/previewssettingspage.cpp 07cd73e33e9676f96c7f6d8d81f8eace297c94c8 
>   src/settings/kcm/kcmdolphingeneral.cpp fb3956880a273c8586aa6fa7f151f018ea2a5b72 
>   src/settings/kcm/kcmdolphinnavigation.cpp 0b2729c330e07e929ac9e0a698922199e695f615 
>   src/settings/kcm/kcmdolphinservices.cpp 8bfdefebbe8c44df49fbc54b8edb645bf7583bca 
>   src/settings/kcm/kcmdolphinviewmodes.cpp 0859e568abfe5d1c3146172a028c291cfea05d8d 
>   src/settings/serviceitemdelegate.cpp a72dd9ec8598a7e39b0a00f1fa50091d5923265e 
>   src/settings/services/servicessettingspage.cpp f258b53e2707906bff735a9eeb3989fe7ee881e0 
>   src/settings/startup/startupsettingspage.cpp 03258cf04ca76543ac1a65928a159abcc57c4534 
>   src/settings/trash/trashsettingspage.cpp 237a1798788c365e1d9babdf5afa456207934acc 
>   src/settings/viewmodes/viewsettingspage.cpp 21bb1e178129dbe44d8e95a1a056b4cad0669bd4 
>   src/settings/viewpropertiesdialog.cpp dc033365fd18ba1e62974d03bcfb722d7706f56e 
>   src/statusbar/dolphinstatusbar.cpp 166f6ab14411efb0aec163609807b2b2723b5aca 
>   src/statusbar/statusbarspaceinfo.cpp 29135566f1a0ea26e5609f62900e19062940a9c0 
>   src/views/dolphinfileitemlistwidget.cpp f152308410ceeaf1769a2e780ad3ecffc7b4d57d 
>   src/views/dolphinitemlistview.cpp 60c8bb97c0777509b4ec41f0f4f561e7f5858b79 
>   src/views/dolphinremoteencoding.cpp 961a7c80085f6b392076befdee2ed3a6d1bf68b7 
>   src/views/dolphinview.cpp 5023859df789bcfdd0a152d380a1aa931e1d762d 
>   src/views/dolphinviewactionhandler.cpp 99214d61b5f785a527f6672df2b7d4e744a11a29 
>   src/views/draganddrophelper.cpp c0044c96eae9530c18283b039b9368ede99121da 
>   src/views/renamedialog.cpp 60b7b16c1f2e8d18049fb3eb7f8691a4a9a05514 
>   src/views/tooltips/filemetadatatooltip.cpp 11b9ecd1d049093ce8504eddef3299eea1a261e9 
>   src/views/versioncontrol/versioncontrolobserver.cpp 4b0d6502989e8db1e99d3aa8149dffce51f6a9a2 
>   src/views/viewproperties.cpp 05c9935858aeecba142a7224ae16944de0900b92 
> 
> Diff: https://git.reviewboard.kde.org/r/126771/diff/
> 
> 
> Testing
> -------
> 
> automated tests pass
> 
> 
> Thanks,
> 
> Artur Puzio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160128/79ca12c2/attachment.htm>

More information about the kfm-devel mailing list