Review Request 126917: Fix check whether window is closed by session management

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Thu Jan 28 18:58:30 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126917/#review91713
-----------------------------------------------------------


Ship it!




Nice, thanks!

- Emmanuel Pescosta


On Jan. 28, 2016, 1:18 p.m., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126917/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2016, 1:18 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 353548
>     https://bugs.kde.org/show_bug.cgi?id=353548
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> qApp->isSessionRestored() specifies whether the application has been *restored* by session management. This is obviously wrong here. Use qApp->isSavingSession() instead.
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.cpp 81c55e8 
> 
> Diff: https://git.reviewboard.kde.org/r/126917/diff/
> 
> 
> Testing
> -------
> 
> Open multiple tabs and logout. Dolphin doesn't ask for confirmation any more.
> It still asks when closing the window manually.
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160128/7c66b36f/attachment.htm>


More information about the kfm-devel mailing list