Review Request 126904: Avoid checking if the right-clicked folder is in the "Places", and always add the "Add to Places" action to the context menu

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126904/#review91653
-----------------------------------------------------------




src/dolphincontextmenu.cpp (line 430)
<https://git.reviewboard.kde.org/r/126904/#comment62625>

    As this will likely feed the places panel as well, it needs to be dynamic?
    
    => Could you just operate on a global singleton instance (feeding the panel view as well as used for such queries) instead?


- Thomas Lübking


On Jan. 27, 2016, 6:07 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126904/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 6:07 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This prevents that the setup of the PlacesItemModel queries Solid for the available devices, which can take some time.
>     
> Places can be added multiple times now using the context menu, but this has always been possible with drag and drop anyway.
>     
> See https://forum.kde.org/viewtopic.php?f=223&t=130617 for a dicsussion on this topic.
> 
> 
> Diffs
> -----
> 
>   src/dolphincontextmenu.cpp af283cf 
> 
> Diff: https://git.reviewboard.kde.org/r/126904/diff/
> 
> 
> Testing
> -------
> 
> The "Add to Places" entry is always enabled now in the context menu. I never observed a noticeable delay when right-clicking folders, but I am confident that this change removes the delay for the users who saw it.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160127/f9072f06/attachment.htm>