Review Request 126799: Add optional confirmation dialog when hiding file by renaming inline

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126799/#review91283
-----------------------------------------------------------



Do we really need a setting for that? We don't have one for when you create a new file either.

Also the wording "On Unix based systems" is strange. Perhaps, if we want to keep it, only use that when it's actually run on a Unix system? The dialog I mentioned earlier doesn't mention that either.

- Kai Uwe Broulik


On Jan. 18, 2016, 6:26 nachm., Roman Gilg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126799/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 6:26 nachm.)
> 
> 
> Review request for Dolphin and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This patch is based on feature request https://bugs.kde.org/show_bug.cgi?id=356770 and implements a confirmation dialog when the user hides a file by renaming inline. This is meant to help new Unix users by not accidently hiding files.
> 
> It is possible to deactivate the confirmation dialog for future operations, which is saved in the Dolphin config.
> 
> Not yet considered in this basic implementation: Hiding files is generally dangerous for new users. So maybe there should allways be an (optional) warning, not only when editing filenames inline. Extending the backend by implementing the same confirmation dialog in KIO::moveAs() could be an idea for the future.
> 
> 
> Diffs
> -----
> 
>   src/settings/dolphin_generalsettings.kcfg 9ff14d1 
>   src/settings/general/confirmationssettingspage.h e702fe8 
>   src/settings/general/confirmationssettingspage.cpp 264024a 
>   src/views/dolphinview.cpp 5023859 
> 
> Diff: https://git.reviewboard.kde.org/r/126799/diff/
> 
> 
> Testing
> -------
> 
> Arch, Plasma 5.5.3
> 
> 
> Thanks,
> 
> Roman Gilg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160118/6d359da3/attachment.htm>