Review Request 126693: Fix crash when clicking "Configure Dolphin..." in the control menu while a sub menu is open

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126693/
-----------------------------------------------------------

(Updated Jan. 14, 2016, 7:38 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Changes
-------

Submitted with commit ddc050f23596493e8debd2dfd523fd572c098d63 by Frank Reininghaus to branch Applications/15.12.


Bugs: 354558
    https://bugs.kde.org/show_bug.cgi?id=354558


Repository: dolphin


Description
-------

Do not delete sub menus of the control menu explicitly
    
This is not necessary because the sub menus are children of the main menu, such that they are deleted together with the other actions by QMenu::clear().
    
This prevents a crash that can happen if a sub menu is open while another menu action is clicked.
    
Thanks to Fabian Vogt and Wolfgang Bauer for investigating this issue!
    
BUG: 354558
FIXED-IN: 15.12.2


Diffs
-----

  src/dolphinmainwindow.cpp 9b05168 

Diff: https://git.reviewboard.kde.org/r/126693/diff/


Testing
-------

Verified that the crash is not reproducible any more, and checked with Valgrind that this does not cause any memory leaks.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160114/f7189c80/attachment.htm>