Review Request 126718: Take into account QApplication::wheelScrollLines() in mouse wheel events

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126718/#review90963
-----------------------------------------------------------



src/kitemviews/kitemlistcontainer.cpp 
<https://git.reviewboard.kde.org/r/126718/#comment62142>

    revert



src/kitemviews/kitemlistcontainer.cpp (line 186)
<https://git.reviewboard.kde.org/r/126718/#comment62141>

    revert



src/kitemviews/kitemlistcontainer.cpp (line 197)
<https://git.reviewboard.kde.org/r/126718/#comment62140>

    Please move the multiplication in front of the division, to avoid problems of rounding towards zero resulting from integer divisions, and thus wrong number of steps. (14/15 * x with x>1 will always give you the result 0, while 14 * x/15 will produce the right number of steps)


Thanks for the patch!

Can you please apply the same changes to KItemListSmoothScroller as well?

- Emmanuel Pescosta


On Jan. 11, 2016, 6 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126718/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2016, 6 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> when setting a different "mouse wheel scrolls by" value in the mouse kcm, the user expects every view to scroll more or less accordingly (even if it's not strictlya text view)
> This makes the scroll in dolphin take that into account
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kitemlistcontainer.cpp c9d521c 
> 
> Diff: https://git.reviewboard.kde.org/r/126718/diff/
> 
> 
> Testing
> -------
> 
> with the default value (3) it should scroll with more or less the same speed it used to have
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160112/32c8bcf2/attachment.htm>