Review Request 126718: Take into account QApplication::wheelScrollLines() in mouse wheel events

[Marco Martin]

> On Jan. 11, 2016, 4:44 p.m., Aleix Pol Gonzalez wrote:
> > src/kitemviews/kitemlistcontainer.cpp, line 204
> > <https://git.reviewboard.kde.org/r/126718/diff/1/?file=430377#file430377line204>
> >
> >     What? xD
> >     
> >     Should it be `4*wheelScroolLines`?
> 
> Marco Martin wrote:
>     since numSteps is now 3 times bigger i wanted to balance somewhere else
> 
> Aleix Pol Gonzalez wrote:
>     Well, it's as bigger as `qApp->wheelScrollLines()`, so it should be compensated with the same magnitude. You're always doing it by 3 despite `qApp->wheelScrollLines()` could be any integer.
> 
> Marco Martin wrote:
>     if it's compensated by the same magnitude then the setting wouldn't have effects again, no?
> 
> Marco Martin wrote:
>     the idea was with default settings scrolling more or less as now, but changing a lot depending from the settings
> 
> Aleix Pol Gonzalez wrote:
>     Then you can divide it directly within `numSteps`? Or you're doing it here for "integer purposes"?

there wouldn't be difference between 1 and 3 lines?


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126718/#review90916
-----------------------------------------------------------


On Jan. 11, 2016, 5 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126718/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2016, 5 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> when setting a different "mouse wheel scrolls by" value in the mouse kcm, the user expects every view to scroll more or less accordingly (even if it's not strictlya text view)
> This makes the scroll in dolphin take that into account
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kitemlistcontainer.cpp c9d521c 
> 
> Diff: https://git.reviewboard.kde.org/r/126718/diff/
> 
> 
> Testing
> -------
> 
> with the default value (3) it should scroll with more or less the same speed it used to have
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160112/8ce4d72b/attachment.htm>