Review Request 126718: Take into account QApplication::wheelScrollLines() in mouse wheel events

Aleix Pol Gonzalez aleixpol at kde.org
Mon Jan 11 16:44:53 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126718/#review90916
-----------------------------------------------------------



src/kitemviews/kitemlistcontainer.cpp (line 203)
<https://git.reviewboard.kde.org/r/126718/#comment62114>

    What? xD
    
    Should it be `4*wheelScroolLines`?



src/kitemviews/private/kitemlistsmoothscroller.cpp (line 215)
<https://git.reviewboard.kde.org/r/126718/#comment62115>

    dd


- Aleix Pol Gonzalez


On Jan. 11, 2016, 5:36 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126718/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2016, 5:36 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> when setting a different "mouse wheel scrolls by" value in the mouse kcm, the user expects every view to scroll more or less accordingly (even if it's not strictlya text view)
> This makes the scroll in dolphin take that into account
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kitemlistcontainer.cpp c9d521c 
>   src/kitemviews/private/kitemlistsmoothscroller.cpp 2bd467a 
> 
> Diff: https://git.reviewboard.kde.org/r/126718/diff/
> 
> 
> Testing
> -------
> 
> with the default value (3) it should scroll with more or less the same speed it used to have
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160111/4f421770/attachment.htm>


More information about the kfm-devel mailing list