Review Request 123883: DolphinSearchBox: Add a "More search tools..." menu button
Gregor Mi
codestruct at posteo.org
Fri Feb 19 09:30:29 GMT 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123883/
-----------------------------------------------------------
(Updated Feb. 19, 2016, 9:30 a.m.)
Review request for Dolphin and Emmanuel Pescosta.
Changes
-------
- Fix mem-leak by using QScopedPointer
- Make label text consistent
Repository: dolphin
Description
-------
Adds a "More search tools..." button to the DolphinSearchBox.
Additionally, moves the "More/Fewer options" button from right to left to reduce the mouse travelling distance when the dolphin is maximized on a large screen (see screenshots)
The current location url will be passed to the search tool to set the initial search root directory.
Diffs (updated)
-----
src/search/dolphinsearchbox.h a806174760521bb66350721b506583c8c37a6b33
src/search/dolphinsearchbox.cpp 743d9113a9ae0f7820d1bed594462a208b2883c3
Diff: https://git.reviewboard.kde.org/r/123883/diff/
Testing
-------
File Attachments
----------------
Currently there is a long mouse traveling distance
https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/8d717a70-215d-4587-89d0-2fee89263731__MoreOptionsTravellingDistance.png
"More search tools" and the "More/fewer options" buttons moved more to the left
https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/3009c4e7-5666-4377-bf39-5ec1967858e6__MoreSearchTools.png
Thanks,
Gregor Mi
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160219/45332035/attachment.htm>
More information about the kfm-devel
mailing list