Review Request 126927: Support KFileMetadata OriginUrl as "Downloaded From"

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126927/#review92242
-----------------------------------------------------------



Note that this makes Dolphin require a newer KF5 version than before. I've just increased the required version to 5.19, such that it fails at CMake stage, and not during compilation, if the installed KF5 version is too old: https://quickgit.kde.org/?p=dolphin.git&a=commit&h=6c5930c229c8b96aae45e19ad4b7a1c57caa6ddc

- Frank Reininghaus


On Feb. 9, 2016, 9:11 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126927/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 9:11 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This brings back the functionality to show where a file originally was downloaded from using xattr originUrl.
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kfileitemmodel.h 167f508 
>   src/kitemviews/kfileitemmodel.cpp 5f6fed0 
>   src/kitemviews/private/kbaloorolesprovider.cpp 920ce06 
> 
> Diff: https://git.reviewboard.kde.org/r/126927/diff/
> 
> 
> Testing
> -------
> 
> I wanted to make the column shown by default when in the downloads folder and in column view but failed.
> 
> Also, Dolphin doesn't seem to enforce a maximum column width, so your view suddenly scrolls horizontally for kilometers as URLs can get quite long.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/30/9f5c6e4c-93d5-4256-866e-44ec74133d55__Screenshot_20160130_202825.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160210/be1296c8/attachment.htm>