Review Request 126904: Avoid checking if the right-clicked folder is in the "Places", and always add the "Add to Places" action to the context menu

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126904/
-----------------------------------------------------------

(Updated Feb. 10, 2016, 9:38 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin and Thomas Lübking.


Changes
-------

Submitted with commit d094c8ffe64d226d5afef50693a3bb04b360ed7b by Frank Reininghaus to branch master.


Repository: dolphin


Description
-------

This prevents that the setup of the PlacesItemModel queries Solid for the available devices, which can take some time.
    
Places can be added multiple times now using the context menu, but this has always been possible with drag and drop anyway.
    
See https://forum.kde.org/viewtopic.php?f=223&t=130617 for a dicsussion on this topic.


Diffs
-----

  src/dolphincontextmenu.cpp af283cf 

Diff: https://git.reviewboard.kde.org/r/126904/diff/


Testing
-------

The "Add to Places" entry is always enabled now in the context menu. I never observed a noticeable delay when right-clicking folders, but I am confident that this change removes the delay for the users who saw it.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160210/efd90ecf/attachment.htm>