Review Request 129664: Fix updating of new item menu when changing tabs

[Elvis Angelaccio]

> On Dec. 18, 2016, 10:18 p.m., Elvis Angelaccio wrote:
> > Tested and fixes the bug, but... why does `activeViewContainer()` return an inactive container? Please add Emmanuel as reviewer, he may know better than me what's going on here.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     I'm not sure if I understand the question? activeViewContainer() should return the active container in the tab page you query.

Right, it's not inactive as I thought. The `setActive(true)` call is the only way to trigger the `writeStateChanged` signal in the view...


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129664/#review101499
-----------------------------------------------------------


On Dec. 25, 2016, 12:36 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129664/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2016, 12:36 p.m.)
> 
> 
> Review request for Dolphin, Elvis Angelaccio and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Correctly set the active statuts of views when changing tabs.
> 
> 
> Diffs
> -----
> 
>   src/dolphintabwidget.h 7b3a18814 
>   src/dolphintabwidget.cpp 22674d1bd 
> 
> Diff: https://git.reviewboard.kde.org/r/129664/diff/
> 
> 
> Testing
> -------
> 
> before: right click in home folder, see create new enabled, open tab, go to /usr, right click and see it is disabled, switch back to first tab and right click, and it is still disabled.
> 
> after: it is enabled and disabled as appropriate when switching tab.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161227/35b57bc3/attachment.htm>