Review Request 129664: Fix updating of new item menu when changing tabs

Elvis Angelaccio elvis.angelaccio at kde.org
Sun Dec 18 22:18:21 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129664/#review101499
-----------------------------------------------------------



Tested and fixes the bug, but... why does `activeViewContainer()` return an inactive container? Please add Emmanuel as reviewer, he may know better than me what's going on here.

- Elvis Angelaccio


On Dec. 17, 2016, 1:26 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129664/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2016, 1:26 p.m.)
> 
> 
> Review request for Dolphin and Elvis Angelaccio.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Correctly set the active statuts of views when changing tabs.
> 
> 
> Diffs
> -----
> 
>   src/dolphintabwidget.h 7b3a18814 
>   src/dolphintabwidget.cpp 22674d1bd 
> 
> Diff: https://git.reviewboard.kde.org/r/129664/diff/
> 
> 
> Testing
> -------
> 
> before: right click in home folder, see create new enabled, open tab, go to /usr, right click and see it is disabled, switch back to first tab and right click, and it is still disabled.
> 
> after: it is enabled and disabled as appropriate when switching tab.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161218/13bc2c2f/attachment.htm>


More information about the kfm-devel mailing list