Review Request 129619: Dolphin: directory loading progress

Don Nguyen don78colorado at gmail.com
Mon Dec 5 17:36:56 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129619/
-----------------------------------------------------------

Review request for Dolphin.


Repository: dolphin


Description
-------

Everything is already set up to show the directory loading progress in the status bar, but the signal KFileItemModel::directoryLoadingProgress is never emmited anywhere.  I connected it to KFileItemModelDirLister::percent.


Diffs
-----

  src/kitemviews/kfileitemmodel.cpp 05f85a6 

Diff: https://git.reviewboard.kde.org/r/129619/diff/


Testing
-------

This was difficult to test because I had a hard time finding a directory that didn't load almost immediately.  I was able to verify the fix by listing a remote directory of 20,000 files (see screenshot)


File Attachments
----------------

directory loading progress in status bar
  https://git.reviewboard.kde.org/media/uploaded/files/2016/12/05/409a24a9-3272-4ab9-8e2d-18d309e33e64__loadProgress.png


Thanks,

Don Nguyen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161205/71879803/attachment.htm>


More information about the kfm-devel mailing list