Review Request 129601: Left mouse double click fires a "go up"

[Don Nguyen]

> On Dec. 4, 2016, 6:31 a.m., Don Nguyen wrote:
> > It looks good.  I would reword it and change the signal from doubleClickedBesideItem() to something like doubleClickedNoItem() or even just doubleClicked().  The current wording makes me think that you have to double click beside an item and that the item has some significance, but really, you just have to double click anywhere but on an item.
> 
> Lorenz Haas wrote:
>     Yes, doubleClickedNoItem() is a better name and more easily to understand. I decided against a plain doubleClicked() since I would expect auch a signal also to be emitted when itemActivated() is and therefor it would be useless for the current feature.

Also, maybe change the description from "Double click beside item changes to parent directory" in settings to something like "Double clicking on empty area changes to the folder above the current folder."  The "Changes to the folder above the current folder" is the text used in the Dolphin Handbook to describe the Go Up menu action.


- Don


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129601/#review101260
-----------------------------------------------------------


On Dec. 4, 2016, 8:09 a.m., Lorenz Haas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129601/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2016, 8:09 a.m.)
> 
> 
> Review request for Dolphin and KDE Usability.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> If you double click without activating an item, you go up the folder hierarchy.
> 
> BUG: 307505
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.cpp e5103fd 
>   src/kitemviews/kitemlistcontroller.h b8a93ed 
>   src/kitemviews/kitemlistcontroller.cpp 1c86ff0 
>   src/settings/dolphin_generalsettings.kcfg c724afc 
>   src/settings/navigation/navigationsettingspage.h 5410a4e 
>   src/settings/navigation/navigationsettingspage.cpp e37a35d 
>   src/views/dolphinview.h 0b0d819 
>   src/views/dolphinview.cpp 4105628 
> 
> Diff: https://git.reviewboard.kde.org/r/129601/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lorenz Haas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161204/474e7cca/attachment.htm>