Review Request 129533: Dolphin: expand all one level, expand all, and collapse all in details view mode
Don Nguyen
don78colorado at gmail.com
Sun Dec 4 07:08:47 GMT 2016
> On Nov. 27, 2016, 11:22 a.m., Heiko Tietze wrote:
> > Your \ is accessed on a German keyboard layout per AltGr (right alt key), would be a really unusual combination with ctrl. The idea was to have the division (ctrl+/) and the multiplication, and to alterate this 'normal' ctrl+ * so users have to remember just the * , which is secured further for the hazardous expand-all-function. Both are easily accesible on the numblock unlike special keys on the various layouts.
> > (Guess these keys are configurable in the shortcuts dialog and we discuss the default only.)
> >
> > The context menu is the first place to look for functions. Keep your stuff there, it doesn't hurt. And also keep in mind that users can hide the menu- and the toolbar.
> >
> > The toolbar buttons need icons, ask Andreas Kainz for support. And in my opinion it's way too much text for a convenience feature. It draws a lot of attention to these functions just because of the verbose labels. Solution 1: icon only, Solution 2: shorter labels (Expand One, Expand Full, Collapse [Full]), Solution 3: Use a split/menu button and list the functions there, Solution 4: Ignore my objection ;-).
> >
> > Looptest: "Could not enter" ist not really actionable. How about 'Trees can have up to 256 levels. Dolphin cannot handle this depth, use file system functions' (this is just a draft to illustrate the idea of actionable).
> >
> > PS: If you worry about the shortcuts we could run a quick poll.
>
> Don Nguyen wrote:
> I put some thought into the naming of the functions with respect to their meanings in the contexts where there is a selection and no selection, along with your suggestion, and came up with the following proposal: Expand, Expand Full, Collapse All
> Expand - If there is a selection, expand the selection once. Otherwise expand everything once.
> Expand Full - If there is a selection, expand the selected items completely. Otherwise expand everything completely.
> Collapse All - Collapse everything. The reason why I chose All here instead of Full is because Expand Full can operate on a selection, whereas collapse all will always collapse everything. I think of "All" as representing what items to perform the functions on and "Full" as representing how to perform the function.
> This simplification will allow the most flexibility, functionality, while minimizing the amount of functions and texts. What do you think?
>
> Is the e-mail address listed in identity.kde.org a good way to contact Andreas Kainz for icon support?
>
> Looptest was just to demonstrate that the new convenience expand functions will stop when an error is encountered. The error message is an existing behavior coming from KIO so I don't want to alter it in this patch and leave it to be addressed in another patch.
>
> My main concern about the shortcuts is that I would like the default shortcuts to be accessible on a keyboard with no numpad(many laptops) if possible. I could change \ to /. Ctrl+ *,%,/ would all be accessible from my laptop. Would that work? The Ctrl+Shift+* is not possible to generate with my keyboard because on my laptop the * is accessed with a Shift+8 combination. On my laptop Ctrl+*, is accessed via Ctrl+Shift+8.
>
> Heiko Tietze wrote:
> Expand, Expand Full, Collapse All with the underlying functionality is brilliant. Good work!
> Pinging Andreas directly, just in case identidy is wrong.
> Looptest: acknowledged
> Shortcuts: Don't we have default and alternate shortcuts? One for 104/105 keyboards and the other for notebooks. Ctrl+/ and ctrl+ * are good (numpad or shift 7 or shift + on German layout) but not %. How about ctrl with + (expand one level), * (expand full) and - (collapse all)? Easy to reach with the numblock but also directly on the keys. Args... it's zoom. So how about these keys accelerated with alt, which fits into the alt+left/right/home etc. navigation?
I've just uploaded the diff with the proposed changes.
I am not familiar with the different shortcuts for and with different keyboards. I hope the new shortcuts will work. Let me know if you have any other suggestions.
To request support for icons, should I add Andreas to the list of reviewers, or what other methods should I use?
- Don
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129533/#review101135
-----------------------------------------------------------
On Dec. 4, 2016, 7:01 a.m., Don Nguyen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129533/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2016, 7:01 a.m.)
>
>
> Review request for Dolphin and KDE Usability.
>
>
> Bugs: 196772
> https://bugs.kde.org/show_bug.cgi?id=196772
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> Implemented functions: Expand, Expand Full, and Collapse All. They are available via the context menu in details view mode as well as custom toolbar buttons as Thomas explained. They are also available under the View and Control menus and are disabled when not in details view mode. See screenshots.
> Expand - If there is a selection, expand the selection once. Otherwise expand everything once.
> Expand Full - If there is a selection, expand the selected items completely. Otherwise expand everything completely.
> Collapse All - Collapse everything.
>
>
> Diffs
> -----
>
> src/dolphincontextmenu.h f67300d
> src/dolphincontextmenu.cpp ed3f643
> src/dolphinmainwindow.cpp e5103fd
> src/dolphinui.rc f197af4
> src/kitemviews/kfileitemmodel.h 8a0df72
> src/kitemviews/kfileitemmodel.cpp 05f85a6
> src/views/dolphinview.h 0b0d819
> src/views/dolphinview.cpp 4105628
> src/views/dolphinviewactionhandler.h eb375b5
> src/views/dolphinviewactionhandler.cpp 858f929
>
> Diff: https://git.reviewboard.kde.org/r/129533/diff/
>
>
> Testing
> -------
>
> make test passes
> manual testing including:
> expand all on an Android SDK folder which yielded in 3180 folders, and 30993 files
> collapse all on above situation
> expand all on a directory that contains a symbolic link to a directory containing itself - operation will stop with error when expansion reaches a path that KCoreDirLister doesn't accept(see looptest screenshot)
> changing directories in the middle of an expand all operation
> changing directories in the middle of a restore expanded directories operation
> canceling in the middle of an expand all operation
> canceling in the middle of a restore expanded directories operation
> canceling in the middle of an expand all operation or restore expand directory operation, and then expanding an item manually with mouse click
> collapse all in the middle of an expand all operation
> collapse all in the middle of a restore expanded directories operation
> switched view modes and verified items are enabled only in details view mode
>
>
> File Attachments
> ----------------
>
> looptest
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/25/f02b7e85-d0b3-4153-ae0d-e86a4ddfc916__looptest.png
> context-menu-disabled
> https://git.reviewboard.kde.org/media/uploaded/files/2016/12/04/1fcc4412-e5f2-4c31-92bf-b828eea938f7__contextdisabled.png
> context-menu-with-selection
> https://git.reviewboard.kde.org/media/uploaded/files/2016/12/04/8a4709e5-d674-4f74-8cbc-a71841db7c36__selectioncontextenabled.png
> view-menu-enabled
> https://git.reviewboard.kde.org/media/uploaded/files/2016/12/04/1ddaa88d-e0aa-441a-a840-5e2cdc06fbf2__viewmenuenabled.png
>
>
> Thanks,
>
> Don Nguyen
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161204/14d3bd61/attachment.htm>
More information about the kfm-devel
mailing list