Review Request 129589: Avoid opening duplicate Properties dialogs

[Christoph Feck]

> On Nov. 30, 2016, 1:06 a.m., Christoph Feck wrote:
> > src/views/dolphinviewactionhandler.cpp, line 57
> > <https://git.reviewboard.kde.org/r/129589/diff/3/?file=486839#file486839line57>
> >
> >     Use member initialization instead of assignment.
> 
> Mario Bereš wrote:
>     I'm not sure how to do that?

See 6 lines above. But keep the same order as in the class definition, otherwise the compiler issues a warning.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129589/#review101182
-----------------------------------------------------------


On Nov. 30, 2016, 12:48 a.m., Mario Bereš wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129589/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 12:48 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 372703
>     https://bugs.kde.org/show_bug.cgi?id=372703
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> You could open duplicate Properties dialogs because every time u hit "Properties" button, a new KPropertiesDialog is created. Now it's stored in class variable until it destroys, if you try to open another KPropertiesDialog it will focus back to already opened one.
> 
> 
> Diffs
> -----
> 
>   src/views/dolphinviewactionhandler.h eb375b5 
>   src/views/dolphinviewactionhandler.cpp 858f929 
> 
> Diff: https://git.reviewboard.kde.org/r/129589/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mario Bereš
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161202/469594b2/attachment.htm>