Review Request 128564: Allow using tab for switching between active splits

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128564/#review98625
-----------------------------------------------------------




src/dolphintabpage.cpp (lines 331 - 332)
<https://git.reviewboard.kde.org/r/128564/#comment66439>

    Better avoid slotViewActivated() and replace it by a more understandable version.
    
    if (m_primaryViewActive) {
       m_secondaryViewContainer->setActive(true);
    } else {
       m_primaryViewContainer->setActive(true);
    }



src/settings/general/behaviorsettingspage.cpp (line 83)
<https://git.reviewboard.kde.org/r/128564/#comment66441>

    split -> split view ?
    
    We already use "split view" e.g. in the startup settings page.



src/views/dolphinview.cpp (line 732)
<https://git.reviewboard.kde.org/r/128564/#comment66440>

    Split -> SplitView ?


- Emmanuel Pescosta


On Aug. 13, 2016, 9:30 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128564/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2016, 9:30 p.m.)
> 
> 
> Review request for Dolphin, Elvis Angelaccio, Emmanuel Pescosta, and Aurélien Gâteau.
> 
> 
> Bugs: 171743
>     https://bugs.kde.org/show_bug.cgi?id=171743
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Based on https://git.reviewboard.kde.org/r/110970/, but with a setting for enabling/disabling.
> 
> The problem with focus doesn't seem to exist anymore.
> 
> 
> Diffs
> -----
> 
>   src/dolphintabpage.h b46daf3 
>   src/dolphintabpage.cpp 0382341 
>   src/settings/dolphin_generalsettings.kcfg 12f1585 
>   src/settings/general/behaviorsettingspage.h 6213734 
>   src/settings/general/behaviorsettingspage.cpp 86a4ad3 
>   src/views/dolphinview.h d1a5d50 
>   src/views/dolphinview.cpp 5466fd3 
> 
> Diff: https://git.reviewboard.kde.org/r/128564/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160825/cf027953/attachment.htm>