Review Request 128563: Preserve selected items when changing folders

Martin Tobias Holmedahl Sandsmark martin.sandsmark at kde.org
Wed Aug 3 18:30:07 BST 2016



> On Aug. 1, 2016, 1:01 a.m., Aleix Pol Gonzalez wrote:
> > src/views/dolphinview.cpp, line 1238
> > <https://git.reviewboard.kde.org/r/128563/diff/1/?file=472641#file472641line1238>
> >
> >     ```
> >     QSet<int> selected = m_container->controller()->selectionManager()->selectedItems().toSet();
> >     ```
> >     ?

It's a custom KItemSet class, it doesn't have a toSet() function unfortunately :(


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128563/#review97959
-----------------------------------------------------------


On July 31, 2016, 4:32 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128563/
> -----------------------------------------------------------
> 
> (Updated July 31, 2016, 4:32 p.m.)
> 
> 
> Review request for Dolphin, Elvis Angelaccio and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Instead of just clearing the selection when going back and forth in history, it now preserves the selected items.
> 
> 
> Diffs
> -----
> 
>   src/dolphinviewcontainer.h 62f9110 
>   src/dolphinviewcontainer.cpp 1c43fc9 
>   src/views/dolphinview.cpp 5466fd3 
> 
> Diff: https://git.reviewboard.kde.org/r/128563/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160803/4ffcc5a4/attachment.htm>


More information about the kfm-devel mailing list