Review Request 125441: [dolphin-plugins]Fix dialog windows captions with KUIT tags

Tomasz Bojczuk seelook at gmail.com
Mon Sep 28 22:28:11 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125441/
-----------------------------------------------------------

Review request for Dolphin and Emmanuel Pescosta.


Repository: dolphin-plugins


Description
-------

I didn't notice it before, but git dialogues had Kuit tags. So i18nc were changed to xi18nc.

P.S.
Unfortunately, with all fileviewgitplugin.cpp actions entries in my request: https://git.reviewboard.kde.org/r/125052/ 
I used xi18nd instead, so all their translations become not compatible. 
Seems to be even worst... 
When I tried to change menu actions texts wrapping into xi18nc, there were no more translations.
Looks like their were cleared or so with 15.08.1 release.
I have older version of kde-l10n package from 15.08.0 and after I installed it, the translations come back.

So, What to do? 
1. Wait for 15.08.2, check are translations there and forget if they are or change to xi18nc if they not?
2. Or change to xi18nc just now?


Diffs
-----

  git/checkoutdialog.cpp 1eaecef 
  git/commitdialog.cpp 06222cf 
  git/pulldialog.cpp d51789e 
  git/pushdialog.cpp 1c82fa3 
  git/tagdialog.cpp 5da01ad 

Diff: https://git.reviewboard.kde.org/r/125441/diff/


Testing
-------

Window captions looks good... and are translated


Thanks,

Tomasz Bojczuk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150928/c2d8fb4f/attachment.htm>


More information about the kfm-devel mailing list