Review Request 125069: [patch] Port dolphin-plugins to KF5 without kdelibs4support

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125069/#review86068
-----------------------------------------------------------



File Attachment: patch3 - patch3
<https://git.reviewboard.kde.org//r/125069/#fcomment462>

    This looks fragile; make it a member var instead?



File Attachment: patch3 - patch3
<https://git.reviewboard.kde.org//r/125069/#fcomment463>

    same here



File Attachment: patch3 - patch3
<https://git.reviewboard.kde.org//r/125069/#fcomment464>

    Why was <application> removed everywhere? Doesn't seem related to porting away from kdelibs4support.



File Attachment: patch3 - patch3
<https://git.reviewboard.kde.org//r/125069/#fcomment465>

    member var for buttonbox



File Attachment: patch3 - patch3
<https://git.reviewboard.kde.org//r/125069/#fcomment466>

    the flag Dialog is not useful


- David Faure


On Sept. 27, 2015, 4:58 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125069/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2015, 4:58 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Remove dependecy of kdelibs4support
> 
> 
> Diffs
> -----
> 
>   svn/fileviewsvnplugin.cpp faf6a0f 
>   svn/fileviewsvnplugin.h 2ba36bf 
>   svn/CMakeLists.txt 1627b92 
>   git/tagdialog.h 60563cd 
>   git/tagdialog.cpp 5da01ad 
>   git/pushdialog.cpp 1c82fa3 
>   git/pulldialog.cpp d51789e 
>   git/pushdialog.h 74da471 
>   git/pulldialog.h 861cb80 
>   git/fileviewgitplugin.h 3148b12 
>   git/fileviewgitplugin.cpp 7af37f0 
>   git/commitdialog.cpp 06222cf 
>   git/commitdialog.h dd5bfbf 
>   git/checkoutdialog.h 6d24c7d 
>   git/checkoutdialog.cpp 1eaecef 
>   git/CMakeLists.txt ea58c77 
>   CMakeLists.txt 76314bf 
> 
> Diff: https://git.reviewboard.kde.org/r/125069/diff/
> 
> 
> Testing
> -------
> 
> 1. KDialog to QDialog + QDialogButtonBox using convert-kdialog.pl
> 2. KLineEdit to QLineEdit
> 3. KTextEdit to QTextEdit
> 4. KVBox, KHBox to QWidget + QVBoxLayout, QWidget + QHBoxLayout using convert-kvbox.pl
> 
> 
> File Attachments
> ----------------
> 
> patch2
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/26/ec4f04f8-adc1-411c-a4ee-de43b0bec11c__patch2
> patch3
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/27/b083b140-2534-449e-993e-1334e96fb4f2__patch3
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150928/eee4d2d1/attachment.htm>