Review Request 125383: [dolphin-plugins]Fix for adding issues for git plugin
Tomasz Bojczuk
seelook at gmail.com
Sat Sep 26 19:28:21 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125383/
-----------------------------------------------------------
(Updated Sept. 26, 2015, 6:28 p.m.)
Status
------
This change has been marked as submitted.
Review request for Dolphin.
Changes
-------
Submitted with commit 012664e2d07b82f9b0b68f4f42812a0e66460359 by Emmanuel Pescosta on behalf of Tomasz Bojczuk to branch Applications/15.08.
Bugs: https://bugs.kde.org/show_bug.cgi?id=352625
http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=352625
Repository: dolphin-plugins
Description
-------
This pach reverts my previous fix, which solved only side effect of the main problem.
Main problem is clearing QProcess working directory of 'git' command when context menu of a file is invoked.
Now working directory is set there instead of clearing. Then 'git' is capable to work with relative file paths.
Diffs
-----
git/fileviewgitplugin.cpp 4b5b1c5
Diff: https://git.reviewboard.kde.org/r/125383/diff/
Testing
-------
Of course....
I uses/using it "even" with real (production) projects.
Thanks,
Tomasz Bojczuk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150926/38e2fd06/attachment.htm>
More information about the kfm-devel
mailing list