Review Request 125247: Add missing KFileItem includes in dolphin-plugins

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Fri Sep 25 20:31:17 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125247/#review85935
-----------------------------------------------------------

Ship it!


Ship It!

- Emmanuel Pescosta


On Sept. 15, 2015, 10:21 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125247/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 10:21 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 352658
>     http://bugs.kde.org/show_bug.cgi?id=352658
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> This fixes a build failure that happens since the KFileItem include was replaced by a forward declaration in Dolphin's kversioncontrolplugin.h in https://quickgit.kde.org/?p=dolphin.git&a=commitdiff&h=bfa4274f58fcf5c873f20210ce6a88277671ccee
> 
> 
> Diffs
> -----
> 
>   git/fileviewgitplugin.h 3e92605 
>   svn/fileviewsvnplugin.h a1eda54 
> 
> Diff: https://git.reviewboard.kde.org/r/125247/diff/
> 
> 
> Testing
> -------
> 
> dolphin-plugins now builds fine for me. If I missed anything, please let me know :-)
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150925/f2ba0426/attachment.htm>


More information about the kfm-devel mailing list