Review Request 125360: Fix KF5Activities being optional.

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125360/#review85934
-----------------------------------------------------------



CMakeLists.txt (line 69)
<https://git.reviewboard.kde.org/r/125360/#comment59308>

    I would prefer changing COMPONENTS to OPTIONAL_COMPONENTS instead. (in theorie it can also be merged with the find_package above, but IMHO an extra find_package for optional components is nicer ;)


- Emmanuel Pescosta


On Sept. 23, 2015, 3:25 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125360/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2015, 3:25 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> If found via find_package(KF5 COMPONENTS Activities) instead, it will
> inherit REQUIRED from the previous call.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a5580e9e01e0024eb36d5a049e6550ace6c52f14 
> 
> Diff: https://git.reviewboard.kde.org/r/125360/diff/
> 
> 
> Testing
> -------
> 
> Configures correctly with/without KF5ACtivities present.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150925/dc72a7fb/attachment.htm>