Review Request 125136: Add an interface which allow plugin to show custom overlay icons

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125136/#review85546
-----------------------------------------------------------


I'm OK with koverlayiconplugin.h going to KIOWidgets.
It would allow using it in KFileWidget at some point.


src/views/versioncontrol/koverlayiconplugin.h (line 45)
<https://git.reviewboard.kde.org/r/125136/#comment59126>

    s/pixmap/icons/



src/views/versioncontrol/koverlayiconplugin.h (line 52)
<https://git.reviewboard.kde.org/r/125136/#comment59127>

    icon -> icons


- David Faure


On Sept. 11, 2015, 9:08 a.m., Olivier Goffart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125136/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2015, 9:08 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Add an interface which allow plugin to show custom overlay icons
> 
> 
> My use case is an owncloud plugin.
> 
> I could not simply use KVersionControlPlugin because it is lacking some state (the shared state).
> Also, that plugin does not let me update only one file at the time. (there is no signal to tell dolphin that only one icon has changed.)  KVersionControlPlugin::versionState is supposed to be blocking because it is called from a thread but then it calls it for all the files sequencially which is slow if there are many files.
> 
> Instead, this new KOverlayPlugin::getOverlays is supposed to return fast. What I do is that if I don't have the thng cached, i return nothing, but then i start the query, and then call the overlaysChanged changed signal.
> 
> 
> I currently put this class in the version control library.  Should it go in KIOWidgets instead? (next to KAbstractFileItemActionPlugin)
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e0f91de 
>   src/kitemviews/kfileitemmodelrolesupdater.h 216b0a5 
>   src/kitemviews/kfileitemmodelrolesupdater.cpp b03fd9c 
>   src/views/versioncontrol/koverlayiconplugin.cpp PRE-CREATION 
>   src/views/versioncontrol/koverlayiconplugin.desktop PRE-CREATION 
>   src/views/versioncontrol/koverlayiconplugin.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125136/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Olivier Goffart
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150917/f43ab775/attachment.htm>