Review Request 125077: Make the uncheckable "Open archives as folder" checkbox checkable again

[Emmanuel Pescosta]

> On Sept. 7, 2015, 10:42 p.m., Frank Reininghaus wrote:
> > Nice fix, looks very reasonable!
> > 
> > I'm still a bit surprised that this (now unneeded) empty widget has such a strange effect which is reproducible (at least for me) only sometimes and only for one of the two checkboxes on the page. If you have gained any insights into this, I would be very curious to know about it :-)

> If you have gained any insights into this, I would be very curious to know about it

No clue ... just thought that this widget could be the 'only' root cause of the problem on this settings page, because it wasn't added to the layout, so random size/position values could lead to the covered checkbox problem ... and it magically fixed the problem :)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125077/#review84974
-----------------------------------------------------------


On Sept. 6, 2015, 7:37 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125077/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2015, 7:37 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 349148
>     https://bugs.kde.org/show_bug.cgi?id=349148
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Remove the dummy widget, which assured that the dialog layout
> was not stretched vertically (vbox align top does the same), to make the
> uncheckable "Open archives as folder" checkbox checkable again.
> 
> 
> Diffs
> -----
> 
>   src/settings/navigation/navigationsettingspage.cpp f9c7a4d 
> 
> Diff: https://git.reviewboard.kde.org/r/125077/diff/
> 
> 
> Testing
> -------
> 
> Is now checkable
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150907/385380ed/attachment.htm>