Review Request 123921: Single instance app

[David Faure]

> On May 28, 2015, 3:29 p.m., Kai Uwe Broulik wrote:
> > Does this need to be an option at all? I think there were plans of making Dolphin an unique application now that the libs it uses are much more mature.
> 
> Vladimir Perepechin wrote:
>     As for me - not at all.
>     As i remember - request for this feature was years ago. (can't find it now), but no one moved dolphin to KUniqueApplication.
>     That's why i decided that developers aren't interested in such behavior, that's why i made it optional.
>     
>     As for me - there is no reason to have several instances of a dolphin.
> 
> Frank Reininghaus wrote:
>     Not sure what you mean with "developers aren't interested in such behavior". If a proposed change is not implemented, then this can have only two good reasons:
>     1. Nobody has implemented it yet because everyone who could do it in principle is busy with other things, or simply did not notice the issue yet because there is always too much going on that needs attention.
>     2. It is not quite clear if the advantages that the change brings outweigh the potential disadvantages.
>     
>     An option does not help in either of these cases. IMHO, an option is only useful if there are valid reasons why large parts of the user base want it either the one way or the other. For the "single instance" issue, I think that this is not the case - users should not notice at all if all Dolphin windows share the same process or not (except for faster startup times and possibly lower memory consumption).
>     
>     As far as I'm concerned, I always thought that having a "Single instance app" is better. In fact, Dolphin used to be a KUniqueApplication, but this was changed many years ago because this has the drawback that a crash brings all windows down. Some libraries that Dolphin used were extremely unstable at that time, which is why having a KUniqueApplication was just not reasonable any more. 
>     
>     Another downside of the "single instance app" approach is that modal dialogs, which KIO used in some places, freeze all windows. This issue has been brought up some time ago when the "single instance app" issue was discussed. However, I think that Dawit did a great job at changing that in KIO in the mean time.

A note about "modal dialogs blocking all windows": this is actually configurable with setWindowModality(Qt::WindowModal), something which we largely under-use in KDE.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123921/#review80930
-----------------------------------------------------------


On May 28, 2015, 8:45 a.m., Vladimir Perepechin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123921/
> -----------------------------------------------------------
> 
> (Updated May 28, 2015, 8:45 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Add option for dolphin to be a single instance app.
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.h 7003e94 
>   src/dolphinmainwindow.cpp f7a7613 
>   src/main.cpp ec68336 
>   src/settings/dolphin_generalsettings.kcfg 9ff14d1 
>   src/settings/startup/startupsettingspage.h 9bcc311 
>   src/settings/startup/startupsettingspage.cpp 48d2a7b 
> 
> Diff: https://git.reviewboard.kde.org/r/123921/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vladimir Perepechin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150906/71d2c538/attachment.htm>