Review Request 125054: Fixed adding files in git repository with Dolphin git plugin
Emmanuel Pescosta
emmanuelpescosta099 at gmail.com
Sat Sep 5 20:28:46 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125054/#review84882
-----------------------------------------------------------
Ship it!
Thanks!
git/fileviewgitplugin.cpp (line 626)
<https://git.reviewboard.kde.org/r/125054/#comment58731>
Please remove this line (we don't want dead code ;) )
- Emmanuel Pescosta
On Sept. 5, 2015, 1:22 a.m., Tomasz Bojczuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125054/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2015, 1:22 a.m.)
>
>
> Review request for Dolphin.
>
>
> Repository: dolphin-plugins
>
>
> Description
> -------
>
> The reason was a difference between KUrl and QUrl in KfileInfo returning paths to files
>
>
> Diffs
> -----
>
> git/fileviewgitplugin.cpp 283b8bc
>
> Diff: https://git.reviewboard.kde.org/r/125054/diff/
>
>
> Testing
> -------
>
> Works like a charm
>
>
> Thanks,
>
> Tomasz Bojczuk
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150905/73c84037/attachment.htm>
More information about the kfm-devel
mailing list