Review Request 125645: Correct parsing remotes/

[Mark Gaiser]

> On okt 29, 2015, 9:40 p.m., Mark Gaiser wrote:
> > git/pulldialog.cpp, line 74
> > <https://git.reviewboard.kde.org/r/125645/diff/2/?file=412740#file412740line74>
> >
> >     Coding style.
> >     Should read:
> >     branch.mid(8, slash - 8);
> 
> Anthony Fieroni wrote:
>     What you mean? 'remotes/origin/Applications/15.08' get 'origin' as section1, 'Applications/15.08' as section2. Code till now is totally broken.

I meant the coding style. The usage of spaces in new code and conforming the coding guidelines.
see https://techbase.kde.org/Policies/Kdelibs_Coding_Style

What you talk about is code functionallity, that shouldn't change by adding spaces in the code.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125645/#review87701
-----------------------------------------------------------


On okt 25, 2015, 6:06 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125645/
> -----------------------------------------------------------
> 
> (Updated okt 25, 2015, 6:06 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Correct parsing remotes/
> 
> 
> Diffs
> -----
> 
>   git/pulldialog.cpp d51789e6adc1077e6aaf4e44c925ff04fc467388 
>   git/pushdialog.cpp 1c82fa32e74bb797805f8bfa1ed6dccd6f80465d 
> 
> Diff: https://git.reviewboard.kde.org/r/125645/diff/
> 
> 
> Testing
> -------
> 
> Correct parsing remotes/, example remotes/origin/Applications/15.08
> 
> NOTE:
> Do not look after //Signals on pulldialog.cpp, but diff encounter problems while kompare shows that patch is fine!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151030/c89cf9a7/attachment.htm>