Review Request 125652: svn modification mark is incorrect, on some cases

[Anthony Fieroni]

> On Окт. 22, 2015, 3:59 след обяд, Emmanuel Pescosta wrote:
> > Does it fix bug 337946? If yes please add it to this review request
> 
> Anthony Fieroni wrote:
>     No, this bug must be fixed in Dolphin. When plugin return 'Unversioned' for directory Dolphin must stop ask, this is for every plugin, case example:
>     svn status
>     ?       test
>     Then all files in test will be NormalVersion. But it's complicated, cause Dolphin load single plugin per view, for me must be plugin for every directory that contains KVersionControlPlugin::fileName(). We can fix it in plugin svn by checking if item is directory and Unversioned to add all it content in m_versionInfoHash. Or to check for 'svn: warning: W155010: The node... was not found' cause right now this is NormalVersion :)

I will make patch to see it :)


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125652/#review87262
-----------------------------------------------------------


On Окт. 16, 2015, 7:55 преди обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125652/
> -----------------------------------------------------------
> 
> (Updated Окт. 16, 2015, 7:55 преди обяд)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Incorrect modification mark on directory, cause it's name is a part of true modified one.
> 
> 
> Diffs
> -----
> 
>   bazaar/fileviewbazaarplugin.cpp dfbd5c16846d4e8978deb28d5208bc358b17f615 
>   svn/fileviewsvnplugin.cpp faf6a0fbd813d3e6e36008fa628dcf0bc7c440a1 
> 
> Diff: https://git.reviewboard.kde.org/r/125652/diff/
> 
> 
> Testing
> -------
> 
> Correct mark modified item, example test/ must not be marked when modification are in test1/, match exact name not only part of them
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151030/2da4b6f3/attachment.htm>