Review Request 125645: Correct parsing remotes/

Mark Gaiser markg85 at gmail.com
Thu Oct 29 21:41:33 GMT 2015



> On okt 25, 2015, 6:06 p.m., Anthony Fieroni wrote:
> > Ship It!

Why do you give yourself a ship it? You're not supposed to do that.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125645/#review87375
-----------------------------------------------------------


On okt 25, 2015, 6:06 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125645/
> -----------------------------------------------------------
> 
> (Updated okt 25, 2015, 6:06 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Correct parsing remotes/
> 
> 
> Diffs
> -----
> 
>   git/pulldialog.cpp d51789e6adc1077e6aaf4e44c925ff04fc467388 
>   git/pushdialog.cpp 1c82fa32e74bb797805f8bfa1ed6dccd6f80465d 
> 
> Diff: https://git.reviewboard.kde.org/r/125645/diff/
> 
> 
> Testing
> -------
> 
> Correct parsing remotes/, example remotes/origin/Applications/15.08
> 
> NOTE:
> Do not look after //Signals on pulldialog.cpp, but diff encounter problems while kompare shows that patch is fine!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151029/f8e7a77b/attachment.htm>


More information about the kfm-devel mailing list