Review Request 125652: svn modification mark is incorrect, on some cases

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125652/#review87262
-----------------------------------------------------------


Does it fix bug 337946? If yes please add it to this review request


bazaar/fileviewbazaarplugin.cpp (line 244)
<https://git.reviewboard.kde.org/r/125652/#comment59942>

    * Please put the concatenation of of the loop into a const QString
    * Coding style: space before and after +



svn/fileviewsvnplugin.cpp (line 212)
<https://git.reviewboard.kde.org/r/125652/#comment59943>

    * Please put the concatenation of of the loop into a const QString
    * Coding style: space before and after +


- Emmanuel Pescosta


On Oct. 16, 2015, 6:55 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125652/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2015, 6:55 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Incorrect modification mark on directory, cause it's name is a part of true modified one.
> 
> 
> Diffs
> -----
> 
>   bazaar/fileviewbazaarplugin.cpp dfbd5c16846d4e8978deb28d5208bc358b17f615 
>   svn/fileviewsvnplugin.cpp faf6a0fbd813d3e6e36008fa628dcf0bc7c440a1 
> 
> Diff: https://git.reviewboard.kde.org/r/125652/diff/
> 
> 
> Testing
> -------
> 
> Correct mark modified item, example test/ must not be marked when modification are in test1/, match exact name not only part of them
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151022/892ec7fe/attachment.htm>