Review Request 125587: Fix detach tab not working when path contains spaces

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125587/#review87161
-----------------------------------------------------------

Ship it!


Looks good!


src/dolphintabwidget.cpp (line 268)
<https://git.reviewboard.kde.org/r/125587/#comment59891>

    Maybe you could use
    
        QStringLiteral("dolphin %1").arg(KShell::joinArgs(args))
        
    here?


- Frank Reininghaus


On Okt. 10, 2015, 2:51 nachm., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125587/
> -----------------------------------------------------------
> 
> (Updated Okt. 10, 2015, 2:51 nachm.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 352420
>     https://bugs.kde.org/show_bug.cgi?id=352420
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Paths with spaces should be quoted, use KShell::joinArgs to fix it.
> 
> 
> Diffs
> -----
> 
>   src/dolphintabwidget.cpp ca626d4 
> 
> Diff: https://git.reviewboard.kde.org/r/125587/diff/
> 
> 
> Testing
> -------
> 
> Detach tab works for paths with spaces
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151020/fecbd14d/attachment.htm>