Review Request 125533: dragon-plugins functionality patch

[Emmanuel Pescosta]

> On Oct. 6, 2015, 2:32 p.m., Anthony Fieroni wrote:
> > Parsing remotes/, example remotes/origin/Applications/15.08, is not correct.
> 
> Anthony Fieroni wrote:
>     Misclick, this was comment of patch1.

https://git.reviewboard.kde.org/r/new/ <- Open new review requests here

Please open a new review request FOR EACH patch file 
instead of attaching all patches to one review request, 
so that we can review your changes via [View Diff]. 

So in the end there should be 4 review requests from you: One with patch1, one with patch2, ...

Thanks! :)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125533/#review86419
-----------------------------------------------------------


On Oct. 6, 2015, 6:41 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125533/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 6:41 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Discussion about functionality, patchs under review
> 
> 
> Diffs
> -----
> 
>   git/pulldialog.cpp 9219e82 
>   git/pushdialog.cpp 5c36932 
> 
> Diff: https://git.reviewboard.kde.org/r/125533/diff/
> 
> 
> Testing
> -------
> 
> One by one patch review, same as their name.
> 1. Correct parsing remotes/, example remotes/origin/Applications/15.08
> 2. Enable commit on modified non confict items, enable show differences on modified or conflict items
> 3. Correct mark modified item, example test/ must not be highlighted when modification are in test1/, match exacte name not only part of them
> 4. Revert on svn files
> ---------------------------
> Discussions:
> 1. Logs, it are needed
> 2. Checkout on single/selected files/folders, git plugin
> 3. git commit -a + push on git/commitdialog
> 
> 
> File Attachments
> ----------------
> 
> patch1
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/10/05/91adf078-70a0-4c9d-a16b-c4ad9cfd4fc5__patch1
> patch2
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/10/05/b2c2a205-711f-4171-98f6-75ca8094cf61__patch2
> patch3
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/10/05/89f7b16d-6fb1-49d9-a682-1e768afc2f6c__patch3
> patch4
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/10/05/a83fd3e3-f6bc-49a1-96e5-abf5d6968495__patch4
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151007/ebd83eaf/attachment.htm>