Review Request 124914: Mercurial dolphin plugin ported to KF5

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124914/#review86406
-----------------------------------------------------------

Ship it!


Thanks for porting the Mercurial plugin! 

Please push it to master


CMakeLists.txt (line 53)
<https://git.reviewboard.kde.org/r/124914/#comment59527>

    No need to repeat expression again, endif() is enough



hg/config-widgets/ignorewidget.cpp (line 91)
<https://git.reviewboard.kde.org/r/124914/#comment59529>

    QLatin1String("/.hgignore")



hg/config-widgets/ignorewidget.cpp (line 111)
<https://git.reviewboard.kde.org/r/124914/#comment59530>

    QLatin1String("/.hgignore")



hg/config-widgets/pluginsettings.cpp (line 52)
<https://git.reviewboard.kde.org/r/124914/#comment59531>

    store the path in a variable and reuse it instead of copying the same code multiple times



hg/servedialog.cpp (line 150)
<https://git.reviewboard.kde.org/r/124914/#comment59528>

    4 spaces


- Emmanuel Pescosta


On Oct. 2, 2015, 12:05 a.m., Tomasz Bojczuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124914/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 12:05 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Plugin to work with hg repos for KF5 & Dolphin 15.08.
> All functionality works plus some small fixes.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 76314bf 
>   hg/CMakeLists.txt 2ee51ca 
>   hg/backoutdialog.h de119b8 
>   hg/backoutdialog.cpp 743a68a 
>   hg/branchdialog.h d1302cb 
>   hg/branchdialog.cpp 336b11f 
>   hg/bundledialog.h 13ac8ca 
>   hg/bundledialog.cpp df18665 
>   hg/clonedialog.h ab6d9f5 
>   hg/clonedialog.cpp 01588d7 
>   hg/commitdialog.h 75740ab 
>   hg/commitdialog.cpp 19d5ec6 
>   hg/commitinfowidget.h 62444db 
>   hg/commitinfowidget.cpp ca8ac03 
>   hg/commititemdelegate.h c276cf8 
>   hg/commititemdelegate.cpp 0c00bec 
>   hg/config-widgets/generalconfig.h 1b76d96 
>   hg/config-widgets/generalconfig.cpp 127f934 
>   hg/config-widgets/ignorewidget.h c8ad0a5 
>   hg/config-widgets/ignorewidget.cpp 107bedb 
>   hg/config-widgets/pathconfig.h 06c1d7b 
>   hg/config-widgets/pathconfig.cpp b9144ac 
>   hg/config-widgets/pluginsettings.h cb652d1 
>   hg/config-widgets/pluginsettings.cpp 59e9d72 
>   hg/configdialog.h f87a7b4 
>   hg/configdialog.cpp dbc429e 
>   hg/createdialog.h 5d8ce15 
>   hg/createdialog.cpp 931afbe 
>   hg/exportdialog.h dd180a9 
>   hg/exportdialog.cpp cc5524b 
>   hg/fileviewhgplugin.h 949d99c 
>   hg/fileviewhgplugin.cpp 98d8604 
>   hg/fileviewhgplugin.desktop 8952a6a 
>   hg/fileviewhgpluginsettings.kcfg d36ef2f 
>   hg/hgconfig.h 5f20ba2 
>   hg/hgconfig.cpp 18a79c2 
>   hg/hgwrapper.h 8d4760f 
>   hg/hgwrapper.cpp 7a4c911 
>   hg/importdialog.h f5686a3 
>   hg/importdialog.cpp f6cea4c 
>   hg/mergedialog.h 3cea6a4 
>   hg/mergedialog.cpp dd034e2 
>   hg/pathselector.h e1a607b 
>   hg/pathselector.cpp 4de36f2 
>   hg/pulldialog.cpp 1b85c4b 
>   hg/pushdialog.cpp f8e2b33 
>   hg/renamedialog.h 921ab3f 
>   hg/renamedialog.cpp a5f6870 
>   hg/servedialog.h b939f7a 
>   hg/servedialog.cpp 4b21ffd 
>   hg/servewrapper.h 1248434 
>   hg/servewrapper.cpp 3336c30 
>   hg/statuslist.h cd62340 
>   hg/statuslist.cpp 59f0332 
>   hg/syncdialogbase.h 8810100 
>   hg/syncdialogbase.cpp fd82f85 
>   hg/tagdialog.h f70c660 
>   hg/tagdialog.cpp 55137a7 
>   hg/updatedialog.h 82dc414 
>   hg/updatedialog.cpp b8f6a76 
> 
> Diff: https://git.reviewboard.kde.org/r/124914/diff/
> 
> 
> Testing
> -------
> 
> It compiles clean and has no KDELibs4Support dependencies.
> 
> 
> Thanks,
> 
> Tomasz Bojczuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151006/d1edf217/attachment.htm>