Review Request 126109: Fix search in dolphin panel

Xuetian Weng wengxt at gmail.com
Thu Nov 19 17:41:03 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126109/
-----------------------------------------------------------

(Updated Nov. 19, 2015, 5:41 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin, Frank Reininghaus and Vishesh Handa.


Changes
-------

Submitted with commit ed3bb94ea095e3ba3e3b96584d817899121e1653 by Weng Xuetian to branch master.


Bugs: 348902
    https://bugs.kde.org/show_bug.cgi?id=348902


Repository: dolphin


Description
-------

addType in baloo calls KFileMetadata::TypeInfo::fromName, but there is no "File" type in kfilemetadata.

If we run the same search with baloosearch from cli
$ baloosearch -t File ''
It will complain 'Type "File" does not exist'.


Diffs
-----

  src/panels/places/placesitemmodel.cpp 013b997 

Diff: https://git.reviewboard.kde.org/r/126109/diff/


Testing
-------

Search in side panel now returns result correctly.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151119/70dbc90b/attachment.htm>


More information about the kfm-devel mailing list