Review Request 123883: DolphinSearchBox: Add a "More search tools..." menu button
Emmanuel Pescosta
emmanuelpescosta099 at gmail.com
Thu Nov 19 10:34:15 GMT 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123883/#review88585
-----------------------------------------------------------
src/search/dolphinsearchbox.cpp (line 384)
<https://git.reviewboard.kde.org/r/123883/#comment60729>
Missing setIcon(QIcon::fromTheme("arrow-down-double")) + setToolButtonStyle(Qt::ToolButtonTextBesideIcon);
- Emmanuel Pescosta
On Nov. 19, 2015, 9:25 a.m., Gregor Mi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123883/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2015, 9:25 a.m.)
>
>
> Review request for Dolphin and Emmanuel Pescosta.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> Adds a "More search tools..." button to the DolphinSearchBox.
>
> Additionally, moves the "More/Fewer options" button from right to left to reduce the mouse travelling distance when the dolphin is maximized on a large screen (see screenshots)
>
> The current location url will be passed to the search tool to set the initial search root directory.
>
>
> Diffs
> -----
>
> src/search/dolphinsearchbox.cpp 743d9113a9ae0f7820d1bed594462a208b2883c3
>
> Diff: https://git.reviewboard.kde.org/r/123883/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Currently there is a long mouse traveling distance
> https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/8d717a70-215d-4587-89d0-2fee89263731__MoreOptionsTravellingDistance.png
> "More search tools" and the "More/fewer options" buttons moved more to the left
> https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/3009c4e7-5666-4377-bf39-5ec1967858e6__MoreSearchTools.png
>
>
> Thanks,
>
> Gregor Mi
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151119/8405b866/attachment.htm>
More information about the kfm-devel
mailing list