Review Request 126109: Fix search in dolphin panel

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126109/#review88574
-----------------------------------------------------------

Ship it!


Thanks for the patch!

Was this change documented somewhere, because this broke all previously working applications (don't break user space) ... ?!

- Emmanuel Pescosta


On Nov. 19, 2015, 9:51 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126109/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 9:51 a.m.)
> 
> 
> Review request for Dolphin, Frank Reininghaus and Vishesh Handa.
> 
> 
> Bugs: 348902
>     https://bugs.kde.org/show_bug.cgi?id=348902
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> addType in baloo calls KFileMetadata::TypeInfo::fromName, but there is no "File" type in kfilemetadata.
> 
> If we run the same search with baloosearch from cli
> $ baloosearch -t File ''
> It will complain 'Type "File" does not exist'.
> 
> 
> Diffs
> -----
> 
>   src/panels/places/placesitemmodel.cpp 013b997 
> 
> Diff: https://git.reviewboard.kde.org/r/126109/diff/
> 
> 
> Testing
> -------
> 
> Search in side panel now returns result correctly.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151119/41f2def7/attachment.htm>