Review Request 123883: Add prototype of a "More search tools..." button

Gregor Mi codestruct at posteo.org
Wed Nov 18 22:26:23 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123883/
-----------------------------------------------------------

(Updated Nov. 18, 2015, 10:26 p.m.)


Review request for Dolphin and Emmanuel Pescosta.


Changes
-------

Move lazy loading code to KMoreTools


Summary (updated)
-----------------

Add prototype of a "More search tools..." button


Repository: dolphin


Description
-------

This is the prototype of a "More search tools..." button added to the DolphinSearchBox.

Additionally, this moves the "More/Fewer options" button from right to left to reduce the mouse travelling distance when the dolphin is maximized on a large screen. Of course, if this violates a higher design goal which I maybe don't know yet, I'll remove this part from the RR.

In a LATER step the following could be done:
- The current location url could be passed to the search tool to set the search root directory.


Diffs (updated)
-----

  src/search/dolphinsearchbox.cpp 743d9113a9ae0f7820d1bed594462a208b2883c3 

Diff: https://git.reviewboard.kde.org/r/123883/diff/


Testing
-------


File Attachments
----------------

Currently there is a long mouse traveling distance
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/8d717a70-215d-4587-89d0-2fee89263731__MoreOptionsTravellingDistance.png
"More search tools" and the "More/fewer options" buttons moved more to the left
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/3009c4e7-5666-4377-bf39-5ec1967858e6__MoreSearchTools.png


Thanks,

Gregor Mi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151118/6ec35486/attachment.htm>


More information about the kfm-devel mailing list