Review Request 126070: [dolphin-plugins] Actually make hg optional (and other plugins while at it)

Andreas Sturmlechner andreas.sturmlechner at gmail.com
Sun Nov 15 15:11:26 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126070/
-----------------------------------------------------------

(Updated Nov. 15, 2015, 3:11 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin and Tomasz Bojczuk.


Changes
-------

Submitted with commit 6e3ab6ed9093ca40700412438e030cc95a2066ea by Andreas Sturmlechner to branch Applications/15.12.


Repository: dolphin-plugins


Description
-------

The existing approach does not work, because if you take KF5WidgetsAddons out of the equation, required KF5XmlGui (among others) will be disabled as well and configure be broken.

Further dependencies could be pushed down into plugin subdirectories, but maybe this patch can still fit into 15.12?


Diffs
-----

  CMakeLists.txt b793655b05906ec1dbd7776bdbfa5932fe993922 
  hg/CMakeLists.txt a5e1c7f4208351c40a771d8383aeff1b52d66203 

Diff: https://git.reviewboard.kde.org/r/126070/diff/


Testing
-------

Built dolphin-plugins with each plugin selected separately, successfully.


Thanks,

Andreas Sturmlechner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151115/38e8840a/attachment.htm>


More information about the kfm-devel mailing list