Review Request 126070: [dolphin-plugins] Actually make hg optional (and other plugins while at it)

[Tomasz Bojczuk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126070/#review88379
-----------------------------------------------------------


Personally, I have no any objections to ship it but truth to be told I have no clear idea how it should looks like... So I'm rather not authorized to do this.

One thing about which I have some doubts - for both approaches - will some package maintainers aware about the new dependencies of dolphin-plugins. KTextEditor is common for the most of other KF5 staff but KWidgetsAddons is not so "popular" - hg plugin would be easy to slide out.

- Tomasz Bojczuk


On Lis 15, 2015, 1:08 rano, Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126070/
> -----------------------------------------------------------
> 
> (Updated Lis 15, 2015, 1:08 rano)
> 
> 
> Review request for Dolphin and Tomasz Bojczuk.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> The existing approach does not work, because if you take KF5WidgetsAddons out of the equation, required KF5XmlGui (among others) will be disabled as well and configure be broken.
> 
> Further dependencies could be pushed down into plugin subdirectories, but maybe this patch can still fit into 15.12?
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b793655b05906ec1dbd7776bdbfa5932fe993922 
>   hg/CMakeLists.txt a5e1c7f4208351c40a771d8383aeff1b52d66203 
> 
> Diff: https://git.reviewboard.kde.org/r/126070/diff/
> 
> 
> Testing
> -------
> 
> Built dolphin-plugins with each plugin selected separately, successfully.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151115/e1c8a502/attachment.htm>