Review Request 125652: svn modification mark is incorrect, on some cases

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Sat Nov 7 16:55:43 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125652/#review88145
-----------------------------------------------------------

Ship it!


LGTM

Btw. 'ship it' is intended for people who review your patches.
Ship it means that your patch is ok and can be pushed.
Ship it doesn't automatically merge your changes unlike for example Github, 
where you can press the merge button in a pull request to get your changes in.

- Emmanuel Pescosta


On Nov. 7, 2015, 5:40 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125652/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2015, 5:40 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Incorrect modification mark on directory, cause it's name is a part of true modified one.
> 
> 
> Diffs
> -----
> 
>   bazaar/fileviewbazaarplugin.cpp dfbd5c1 
>   svn/fileviewsvnplugin.cpp faf6a0f 
> 
> Diff: https://git.reviewboard.kde.org/r/125652/diff/
> 
> 
> Testing
> -------
> 
> Correct mark modified item, example test/ must not be marked when modification are in test1/, match exact name not only part of them
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151107/e726be5c/attachment.htm>


More information about the kfm-devel mailing list