Review Request 125645: Correct parsing remotes/

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125645/#review88130
-----------------------------------------------------------



git/pushdialog.cpp (line 102)
<https://git.reviewboard.kde.org/r/125645/#comment60450>

    branches[i] -> branch



git/pushdialog.cpp (lines 103 - 105)
<https://git.reviewboard.kde.org/r/125645/#comment60451>

    move this out of the foreach loop (after the foreach) and do m_localBranchComboBox->setCurrentText(branches.at(currentBranchIndex)) instead please


- Emmanuel Pescosta


On Nov. 3, 2015, 6:45 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125645/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 6:45 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Correct parsing remotes/
> 
> 
> Diffs
> -----
> 
>   git/pulldialog.cpp d51789e 
>   git/pushdialog.cpp 1c82fa3 
> 
> Diff: https://git.reviewboard.kde.org/r/125645/diff/
> 
> 
> Testing
> -------
> 
> Correct parsing remotes/, example remotes/origin/Applications/15.08
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151107/3a5865de/attachment.htm>