Review Request 125651: Dolphin-plugins svn commit action

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125651/#review88129
-----------------------------------------------------------

Ship it!


Nice work!


svn/fileviewsvnplugin.cpp (line 441)
<https://git.reviewboard.kde.org/r/125651/#comment60449>

    const



svn/fileviewsvnplugin.cpp (line 449)
<https://git.reviewboard.kde.org/r/125651/#comment60447>

    enabled && (version != NormalVersion)



svn/fileviewsvnplugin.cpp (line 450)
<https://git.reviewboard.kde.org/r/125651/#comment60448>

    enabled && (version == LocallyModifiedVersion)


- Emmanuel Pescosta


On Nov. 3, 2015, 6:31 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125651/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 6:31 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Do not enable commit action permanently
> 
> 
> Diffs
> -----
> 
>   svn/fileviewsvnplugin.h 2ba36bf 
>   svn/fileviewsvnplugin.cpp faf6a0f 
> 
> Diff: https://git.reviewboard.kde.org/r/125651/diff/
> 
> 
> Testing
> -------
> 
> Enable commit on modified non confict items, enable show differences on modified or conflict items
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151107/75e04b99/attachment.htm>