Review Request 125879: svn plugin bug 337946

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Mon Nov 2 23:22:41 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125879/#review87894
-----------------------------------------------------------



svn/fileviewsvnplugin.cpp (lines 208 - 211)
<https://git.reviewboard.kde.org/r/125879/#comment60301>

    return m_versionInfoHash.value(path, NormalVersion);


- Emmanuel Pescosta


On Oct. 30, 2015, 5:56 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125879/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2015, 5:56 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Dolphin ask for item status in Unversioned path
> 
> 
> Diffs
> -----
> 
>   svn/fileviewsvnplugin.cpp faf6a0f 
> 
> Diff: https://git.reviewboard.kde.org/r/125879/diff/
> 
> 
> Testing
> -------
> 
> I show possible fix:
> When plugin return 'Unversioned' for directory Dolphin must stop ask, case example:
> svn status
> ?       test
> Then all files in test will be NormalVersion. Dolphin load single plugin per view, for me must be plugin for every directory that contains KVersionControlPlugin::fileName(). We can fix it in plugin svn by checking if item is directory and Unversioned to add all it content in m_versionInfoHash. Or to check for 'svn: warning: W155010: The node... was not found' cause right now this is NormalVersion :)
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151102/14d51894/attachment.htm>


More information about the kfm-devel mailing list