Review Request 125645: Correct parsing remotes/

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125645/#review87871
-----------------------------------------------------------



git/pulldialog.cpp (line 69)
<https://git.reviewboard.kde.org/r/125645/#comment60287>

    foreach (const QString& branch, branches) ...



git/pulldialog.cpp (lines 72 - 75)
<https://git.reviewboard.kde.org/r/125645/#comment60286>

    Maybe use QString::section here?
    
    QString remote = branch.section('/', 1, 1)
    
    QString name = branch.section('/', 2);



git/pulldialog.cpp (lines 76 - 81)
<https://git.reviewboard.kde.org/r/125645/#comment60288>

    "m_remoteBranches[section1] << section2" should also work (when the dictionary doesn't contain the key, a default constructed value will be added)


- Emmanuel Pescosta


On Oct. 31, 2015, 8:58 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125645/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2015, 8:58 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Correct parsing remotes/
> 
> 
> Diffs
> -----
> 
>   git/pushdialog.cpp 1c82fa3 
>   git/pulldialog.cpp d51789e 
> 
> Diff: https://git.reviewboard.kde.org/r/125645/diff/
> 
> 
> Testing
> -------
> 
> Correct parsing remotes/, example remotes/origin/Applications/15.08
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151102/73c6fcc1/attachment.htm>