Review Request 123940: Use KPluginLoader::factory() when loading KIO::DndPopupMenuPlugin

[Ragnar Thomsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123940/
-----------------------------------------------------------

(Updated May 30, 2015, 2:39 p.m.)


Review request for Dolphin, KDE Frameworks, Emmanuel Pescosta, and Harald Hvaal.


Changes
-------

Check that KPluginFactory->create() returns a valid object.


Repository: kio


Description
-------

This patch fixes an error when loading the DndPopupMenuPlugin of Ark (frameworks branch). DndPopupMenuPlugins use the K_PLUGIN_FACTORY_WITH_JSON macro, and therefore KPluginLoader::factory() should be used instead of KPluginLoader::instance() which is used by KPluginMetaData::instantiate().

The DndPopupMenuPlugin is used by Ark to enable the "Extract here" menu option when dragging an archive in Dolphin.


Diffs (updated)
-----

  src/widgets/dropjob.cpp 63beb0a 

Diff: https://git.reviewboard.kde.org/r/123940/diff/


Testing
-------

The "Extract here" option now appears when dragging an archive in Dolphin (current frameworks branch), and extraction works as expected.


Thanks,

Ragnar Thomsen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150530/eb6568c3/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel