Review Request 123658: If double-click is on empty area, then invoke back.

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123658/#review80950
-----------------------------------------------------------



src/views/dolphinview.cpp (line 729)
<https://git.reviewboard.kde.org/r/123658/#comment55459>

    Instead of removing the filename manually and converting from QUrl to QString and back, I would recommend to use KIO::upUrl(const QUrl&) or find a way to call the KUrlNavigator's goUp() method.


- Frank Reininghaus


On Mai 28, 2015, 11:30 nachm., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123658/
> -----------------------------------------------------------
> 
> (Updated Mai 28, 2015, 11:30 nachm.)
> 
> 
> Review request for Dolphin, KDE Usability and Emmanuel Pescosta.
> 
> 
> Bugs: 307505
>     https://bugs.kde.org/show_bug.cgi?id=307505
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> If mouse double click is done on the empty area, then go to parent directory.
> 
> RR 123929 (kfilewidgets)
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kitemlistcontroller.h b8a93ed 
>   src/kitemviews/kitemlistcontroller.cpp 1c86ff0 
>   src/views/dolphinview.h 24b560f 
>   src/views/dolphinview.cpp d302358 
> 
> Diff: https://git.reviewboard.kde.org/r/123658/diff/
> 
> 
> Testing
> -------
> 
> Works fine.
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150529/e6cb6ea3/attachment.htm>